Skip to content

Conversation

@theyostalservice
Copy link
Contributor

Resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Nov 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link
Contributor Author

theyostalservice commented Nov 7, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 95.58824% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.77%. Comparing base (ef95e92) to head (3bc5c35).

Additional details and impacted files
@@                                  Coverage Diff                                  @@
##           patricky/fix-metric-name-validation-and-add-tests   #12157      +/-   ##
=====================================================================================
- Coverage                                              91.93%   88.77%   -3.17%     
=====================================================================================
  Files                                                    203      203              
  Lines                                                  24847    24905      +58     
=====================================================================================
- Hits                                                   22844    22109     -735     
- Misses                                                  2003     2796     +793     
Flag Coverage Δ
integration 88.77% <95.58%> (-0.05%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 88.77% <95.58%> (-3.17%) ⬇️
Integration Tests 88.77% <95.58%> (-0.05%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@theyostalservice theyostalservice changed the base branch from main to graphite-base/12157 November 8, 2025 00:36
@theyostalservice theyostalservice force-pushed the patricky/add-new-metric-yaml branch from b833b17 to 77e7cc4 Compare November 8, 2025 00:36
@theyostalservice theyostalservice changed the base branch from graphite-base/12157 to patricky/fix-metric-name-validation-and-add-tests November 8, 2025 00:36
@theyostalservice theyostalservice force-pushed the patricky/add-new-metric-yaml branch from 77e7cc4 to 4f23379 Compare November 8, 2025 01:11
@theyostalservice theyostalservice force-pushed the patricky/add-new-metric-yaml branch from 4f23379 to 3bc5c35 Compare November 8, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants